grpc-js: Implement retries #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Nov 17, 2022
| for (const value of obj.nonFatalStatusCodes) { | ||
| if (typeof value === 'number') { | ||
| if (!Object.values(Status).includes(value)) { | ||
| throw new Error('Invlid method config hedging policy: nonFatalStatusCodes value not in status code range'); |
There was a problem hiding this comment.
Nit: s/Invlid/Invalid/g
It appears in three places in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the actual functionality of gRFC A6: Client Retries. The main changes are:
RetryingCallclass, which implements the retry functionality.SubchannelCallclass to report what RST_STREAM code ended a stream, if any, and theLoadBalancingCallclass to use that information to change what call progress it reports with the status.ResolvingLoadBalancerto pass the service config to the channel along with the config selector when name resolution completes.The tests mainly just test the basic functionality: that the client can make requests in various configurations, and that when retries or hedging are configured, the client makes the appropriate number of attempts per call.