Fix grpc-message typo in call-stream.ts
#2213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clww
force-pushed
the
grpc-js_handleTrailers_decodeURI_exception
branch
from
488f189
to
a6e4f8f
Compare
murgatroid99
requested changes
Aug 30, 2022
|
The EasyCLA status hasn't been updated after I signed (probably related to multiple email associtaed with my GH account?). Update: CLA passed |
Co-authored-by: Michael Lumish <mlumish@google.com>
|
Unfortunately, the change needs to be against the v1.6.x branch for me to publish it, and switching the branch target for this PR pulls in the commits from master. I will make the change myself in #2216. |
|
I published the updated fix in version 1.6.12 |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #2210, error handling code was added for
decodeURI(metadataMap['grpc-message']), but there is a typo in thecatchblock wheregrpc-messagewas written asgrpc-messageswith an extra "s".