grpc-js: Fix shutting down subchannels in separate pools #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
force-pushed
the
grpc-js_refcounts
branch
from
cf4c79f
to
3251422
Compare
nicolasnoble
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the subchannel pool behave the same whether they are global or local. The main issue was that not calling
subchannel.refwhen creating the subchannel resulted in the subchannel shutting down but staying in the pool when its refcount reached 0, and then the pool could still use it. This is counter to the intention that a subchannel should only be shut down when it will never be used again. Once that is removed, the cleanup timer becomes useful to avoid filling the pool up with unused subchannels, and the result is that theglobalconstructor parameter doesn't do anything anymore.I also changed the subchannel shutdown behavior to transition to IDLE instead of TRANSIENT_FAILURE. In theory, both of those should be fine there because the important thing is closing and discarding the connection, but TRANSIENT_FAILURE is more disruptive if the shutdown is in error.