grpc-js: Fix exitIdle propagation and DNS IP result backoff
#2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2031. The main issue was the code in
load-balancer-child-handler.ts: it's just a copy/paste error, and the result is that calls toexitIdlewould not be propagated to child LB policies. That meant that when a new call tried to kick an IDLE LB policy, it would not happen, and it would only eventually leave IDLE when it got a new address list from the resolver. This problem was exacerbated by the missingbackoff.resetcall indns-resolver.ts. The backoff is meant to wait an increasing amount of time after each failure, but because it was not reset there it would also wait an increasing amount of time after each successful IP address resolution.