grpc-js: Add backoff to DNS resolution attempts #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanley-cheung
approved these changes
Jan 14, 2022
| @@ -119,6 +122,18 @@ class DnsResolver implements Resolver { | |||
| details: `Name resolution failed for target ${uriToString(this.target)}`, | |||
| metadata: new Metadata(), | |||
| }; | |||
|
|
|||
| const backoffOptions: BackoffOptions = { | |||
| initialDelay: channelOptions['grpc.initial_reconnect_backoff_ms'], | |||
There was a problem hiding this comment.
what if the key doesn't exist? is it oK?
There was a problem hiding this comment.
Then the value will be undefined, so the BackoffTimeout will fall back to the default value, which is 1000 ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to address the increased DNS resolution traffic when using round robin reported in #2023. With this change, any single channel will space out DNS requests based on the configured connection backoff settings.