Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js-xds: Add more missing files, add distrib test #2021

Merged

Conversation

murgatroid99
Copy link
Member

This fixes #2020, and the distrib test should stop this kind of thing from happening in the future.

Copy link
Contributor

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one question

test/distrib/distrib-test.js Outdated Show resolved Hide resolved
test/distrib/run-distrib-test.sh Show resolved Hide resolved
test/distrib/run-distrib-test.sh Show resolved Hide resolved
@murgatroid99 murgatroid99 merged commit 37b9ec6 into grpc:@grpc/grpc-js@1.5.x Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants