grpc-js: Send backoffOptions to BackoffTimeout #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for the PR. This looks like a good change. I am not allowed to merge it until you sign the CLA. |
|
I have signed the CLA but the PR still appears as unauthorized. What should I do next? |
|
It looks like you are a different GitHub user than the one that created the commit. The CLA bot comment says that the commit is not authorized, which means that the CLA was not signed for that user. You can fix this by changing the commit to have your email as the committer, or by signing the CLA for that other GitHub user. |
|
Fixed |
murgatroid99
approved these changes
Dec 13, 2021
|
I have published this in version 1.4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the BackoffOptions to the BackoffTimeout just as in subchannel.ts, line 221. Without this code, grpc.initial_reconnect_backoff_ms and grpc.max_reconnect_backoff_ms are not used at all in the gRPC client and the retry will always use the default values (1000 and 120000)