grpc-js: Provide full certificate in checkServerIdentity callback
#1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all of the certificate info that Node can provide to the object passed to the
checkServerIdentitycallback. The previous restriction was for compatibility with thegrpcpackage, but with the deprecation of that package that is less valuable. This is a non-breaking change because it only adds properties to the object that is provided to the API user.This PR accomplishes essentially the same thing as #1866. I requested some changes in that PR and the contributor never responded, and now there is additional demand for this improvement in #1965, so I did it myself.