grpc-js: stricter function check than instanceof #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instanceof does not work in vm context
packages/grpc-js/src/client.ts
Outdated
| @@ -198,9 +198,9 @@ export class Client { | |||
| options: CallOptions; | |||
| callback: UnaryCallback<ResponseType>; | |||
| } { | |||
| if (arg1 instanceof Function) { | |||
| if (Object.prototype.toString.call(arg1) === '[object Function]') { | |||
There was a problem hiding this comment.
Can you extract this condition into an isFunction function?
There was a problem hiding this comment.
have updated in the latest commit
|
It looks like this doesn't compile. The test log is here: https://source.cloud.google.com/results/invocations/f8f4ecea-d9b2-4d70-8893-604b5a7f30b0/targets/grpc%2Fnode%2Fpull_request%2Flinux/log. Can you fix that? It might help to make the return value of |
murgatroid99
approved these changes
Apr 27, 2021
|
This fix is now out in version 1.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instanceof Functiondoes not work in vm context, related to #204 #795 and #1759