Enable path_matching and header_matching xDS interop tests #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterop client logging
|
The xDS interop tests, including the newly enabled test, passed in this run: https://source.cloud.google.com/results/invocations/4b800484-229b-483c-b40e-f570e031aafd/targets |
nicolasnoble
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the additional interop tests enabled by #1715.
This PR includes a major refactor of the matching and route action logic in the xDS resolver class, moving them into separate files and multiple classes. The main purpose was to improve the ability to log them for debugging, but that should also improve readability. The refactor also fixed a bug with how the safe regex header match configuration was handled.