Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js-xds: Fix handling of empty LRS server names #1707

Conversation

murgatroid99
Copy link
Member

The LRS load reporting server name is usually the empty string to indicate that the primary xDS server name should be used, but the empty string is falsey so this was taking the wrong branch and LRS was getting disabled when it should have been used.

@murgatroid99
Copy link
Member Author

xDS tests passed, including the newly enabled test, at https://source.cloud.google.com/results/invocations/f88530c2-fd18-42f8-94fa-4cfcd8cf4a20/targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants