grpc-js-xds: Do traffic splitting and routing in the resolver #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add more LRS logging
This reverts commit 2b451fd.
|
The xDS interop tests, including the newly enabled ones, passed at https://source.cloud.google.com/results/invocations/afea6480-f5fc-40bc-a228-2f5203b8fb1e/targets. This PR includes the fixes from #1707 to get LRS working so that the load_report_based_failover test would pass. |
nicolasnoble
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few changes included in this PR:
xds-client.tsinto the directoryxds-stream-stateXdsClientclass to be a singleton shared by all channels. In particular, it no longer takes the resolver'sServiceConfigwatcher in the constructor. Instead, the resolver now watches for LDS and RDS updates the same way the EDS and CDS load balancers watch for their corresponding updates.GRPC_XDS_EXPERIMENTAL_ROUTING. It creates aConfigSelectoras implemented in grpc-js: Add ConfigSelector to Resolver API and plumb it through the channel #1681 and anXdsClusterManageras implemented in grpc-js-xds: Add XdsClusterManager LB policy #1687.