Move createGoogleDefaultCredentials from grpc-js to grpc-js-xds #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
force-pushed
the
grpc-js-xds_google_default_creds
branch
from
1714d87
to
60eb600
Compare
nicolasnoble
approved these changes
Mar 1, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
createGoogleDefaultCredentialsis implemented using onlygrpc-js's public APIs, and it is only used ingrpc-js-xds, so we can move it to avoid needing a dependency ongoogle-auth-libraryingrpc-js. This addresses #1695 without regressing on #1442.grpc-js-xdsonly guarantees compatibility with Node 10+, not Node 8, so the dependency on the newer version ofgoogle-auth-libraryhere is OK.