grpc-js: Don't propagate non-numeric errors from auth plugins #1690
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two complementary changes: in the channel, only propagate error codes from metadata filters if they are numbers, and in the call credentials filter, explicitly set the UNAUTHENTICATED error code instead of letting errors from the credentials plugin implicitly bubble up.
This should fix the reports from googleapis/nodejs-pubsub#1063 of the error code
ERR_OSSL_PEM_NO_START_LINEgetting propagated from a Node crypto module error.