Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Ref and unref backoff timer #1688

Merged

Conversation

murgatroid99
Copy link
Member

We want the gRPC library to hold the Node process open if and only if there is an active request. The channel is responsible for this while a call has not yet been assigned to a subchannel, and the subchannel is responsible for this after the call has been assigned, until the call ends. In the subchannel, there is always either an http session, or an active backoff timer (or both). So, we ref both of those as long as the subchannel has at least one call. Since the resolving load balancer is never responsible for keeping the process open, we always unref its backoff timer. The same is true of the xDS client, which always operates as a subordinate of another channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants