Create prebuilts for native electron 10 and 11 #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
murgatroid99
reviewed
Feb 4, 2021
|
It looks like some build issues have appeared since we last used this build script. I think it will help if you change |
|
It looks like it will also be necessary to upgrade |
…t/setup-msbuild action
jmeinke
force-pushed
the
native_electron_10_and_11
branch
from
6c26e9c
to
69be33c
Compare
jmeinke
force-pushed
the
native_electron_10_and_11
branch
from
1a534cf
to
f73b869
Compare
|
@murgatroid99 The build was successful 🎉 Thanks for your help on fixing the build issues - it would be great if you could release this soon-ish 😃 |
|
This PR would help us a lot! |
|
@murgatroid99 Could you please release the version to NPM. Thank you! |
|
It's out now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this issue, we can't rely on grpc-js: #1158 (comment)
Therefore, it would be great if you could release a grpc native version with prebuilt binaries for Electron 10.3 or Electron v11.