grpc-js: Loosen dependency on @types/node #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1679. TypeScript does not do module resolution the same way Node does, and one result is that it reintroduces the diamond dependency problem to a system that does not otherwise have it. The solution here is to declare a dependency with a version range so broad that npm's package deduplication logic will always apply, or at least that the constraint here is never the one that prevents it from applying.
This change may cause build problems in the future if there are relevant breaking changes in
@types/node, but the existing dependency is causing build problems now so I consider that an acceptable tradeoff.