grpc-js: Add ConfigSelector to Resolver API and plumb it through the channel #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the first part of gRFC A31: the
ConfigSelector. The purpose of this API is to enable the resolver to provide configuration information and especially routing information that can differ depending on the method and on the metadata. The resolver can return aConfigSelectoralong with other name resolution information, and theResolvingLoadBalancerpasses that along to the channel. The channel calls it before before calling into thePickerthat comes from the load balancer.This change should not cause any observable behavior changes, it's just foundational.