Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Move call to user code out of try block #1672

Merged

Conversation

murgatroid99
Copy link
Member

The main fix here is to move the onReceiveMessage call out of the try block, because that function eventually calls stream.push or the equivalent unary handler function, and the result is that that function is called within the context of that try block and any errors it throws will be misinterpreted as response parsing errors.

This fixes #1661.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants