Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js-xds: Shutdown the xDS client used by the resolver when the channel shuts down #1641

Conversation

murgatroid99
Copy link
Member

A channel that connects to an xds:/// backend creates an internal client connected to an xDS server. Currently that client just always has an active call and holds the process open forever. This change makes it so that when that channel's close method is called, which calls its resolving load balancer's destroy method, that propagates to destroy the resolver, which then shuts down the xDS client, allowing the process to end.

Technically, this is a breaking change in the experimental namespace by adding an additional method to the Resolver interface that would need to be implemented by an implementing class. However, the real point of the experimental version compatibility guarantees is to avoid breaking grpc-js-xds, and since that's not out yet I don't consider it to be a real issue.

@murgatroid99 murgatroid99 merged commit 2e3f9ac into grpc:@grpc/grpc-js@1.2.x Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants