Native: add new Node and Electron versions, bump version #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
approved these changes
Oct 29, 2020
Closed
|
@murgatroid99 since this PR increments the version to 1.24.4, will a tag be released soon in github/npm? |
|
I am trying to get a build to succeed. When that happens, I will publish a new version. |
|
@murgatroid99 Could you maybe add electron 10.3 / 11 to the build targets for prebuilds? This would be awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of previous changes set the
package.jsonfile out of sync with the template andbuild.yaml, so I corrected that here.Also add a note in the README specifying the latest version of Node and Electron that we support. We will only have to update that a few times before we stop updating the version support entirely.