grpc-js: Add a timer that holds the event loop open while there are pending calls #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
approved these changes
Sep 17, 2020
packages/grpc-js/src/channel.ts
Outdated
| @@ -230,6 +239,14 @@ export class ChannelImplementation implements Channel { | |||
| new MaxMessageSizeFilterFactory(this.options), | |||
| new CompressionFilterFactory(this), | |||
| ]); | |||
|
|
|||
| this.callRefTimer = setInterval(() => {}, 1 << 31 - 1); | |||
There was a problem hiding this comment.
Isn't there a maxint constant?
There was a problem hiding this comment.
There is Number.MAX_SAFE_INTEGER, but it's larger than that, and Number.MAX_VALUE, which is even larger.
packages/grpc-js/src/channel.ts
Outdated
| @@ -230,6 +239,14 @@ export class ChannelImplementation implements Channel { | |||
| new MaxMessageSizeFilterFactory(this.options), | |||
| new CompressionFilterFactory(this), | |||
| ]); | |||
|
|
|||
| this.callRefTimer = setInterval(() => {}, 1 << 31 - 1); | |||
There was a problem hiding this comment.
Also, https://www.npmjs.com/package/node-noop :-P
There was a problem hiding this comment.
Sadly, that's not even the only package that provides a noop function. We used to depend on one of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1579.
We want to hold the event loop open as long as there is an active call. For most of the lifetime of most calls, this is accomplished by
refing each subchannel as long as it is handling at least one active call. However, that does not account for calls that are never attached to subchannels. This closes that gap by creating an interval timer that lasts for the lifetime of the channel. Werefthat timer as long as there is at least one pending call on the channel that has not been assigned to a subchannel.