Skip to content

Fix incorrectly named grpc-tools flag #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

mavaa
Copy link
Contributor

@mavaa mavaa commented Aug 12, 2020

Was "--generate_package_definitions" (with an s) but should be "generate_package_definition" as in the documentation here: https://github.com/grpc/grpc-node/tree/master/packages/grpc-tools

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Was  "--generate_package_definitions" (with an s) but should be "generate_package_definition" as in the documentation here: https://github.com/grpc/grpc-node/tree/master/packages/grpc-tools
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 12, 2020

CLA Check
The committers are authorized under a signed CLA.

@mavaa
Copy link
Contributor Author

mavaa commented Aug 12, 2020

Lost a few hours on this, hopefully it won't happen to anyone else 😄

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@murgatroid99 murgatroid99 merged commit e37e4f2 into grpc:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants