Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron: Loading non-context-aware native module in renderer; This is deprecated... #1527

Closed
pattrickrice opened this issue Aug 4, 2020 · 2 comments

Comments

@pattrickrice
Copy link

pattrickrice commented Aug 4, 2020

Is your feature request related to a problem? Please describe.

Current Electron release (v9) emits a deprecation warning. v11 will disable the ability to import without context-awareness

(node:86166) Electron: Loading non-context-aware native module in renderer: '<my-project>/node_modules/grpc/src/node/extension_binary/electron-v9.0-darwin-x64-unknown/grpc_node.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.

Describe the solution you'd like

Support for electron v9+

Describe alternatives you've considered

No alternatives, maybe not using grpc-node?

Additional context

n/a

@pattrickrice pattrickrice changed the title Electron: Loading non-context-aware native module in renderer; This is deprecated, see https://github.com/electron/electron/issues/18397 Electron: Loading non-context-aware native module in renderer; This is deprecated... Aug 4, 2020
@murgatroid99
Copy link
Member

I believe this is the same root issue as in #778. This is blocked by nodejs/nan#844, which I filed over a year ago. There has been no recent maintainer activity on that issue so I don't expect it to happen any time soon.

I suggest switching to @grpc/grpc-js, which is the primary gRPC implementation that we will be supporting going forward. That library does not use a native module, so it will not be impacted by this issue.

@murgatroid99
Copy link
Member

At this point, the grpc module has been deprecated for a couple of years, with @grpc/grpc-js as the recommended replacement. We have no plans to update the grpc module to fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants