Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js: Fix credentials type #1459

Merged
merged 1 commit into from
Jun 4, 2020
Merged

grpc-js: Fix credentials type #1459

merged 1 commit into from
Jun 4, 2020

Conversation

greenboxal
Copy link
Contributor

Addresses #1456.

murgatroid99
murgatroid99 approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@murgatroid99 murgatroid99 merged commit 931a7c3 into grpc:master Jun 4, 2020
@murgatroid99 murgatroid99 mentioned this pull request Jun 17, 2020
Merged
@murgatroid99
Copy link
Member

This change is now out in version 1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greenboxal @murgatroid99 @kokoro-team