Prebuilt binaries for s390x #1230
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
| $tool_dir/build_artifact_node_arm.sh | ||
| docker run -e JOBS=8 -e ARTIFACTS_OUT=/var/grpc/artifacts -v $base_dir:/var/grpc alpine_node_artifact /var/grpc/tools/run_tests/artifacts/build_artifact_node.sh --with-alpine |
There was a problem hiding this comment.
This line appears to be redundant with line 80.
| @@ -69,8 +69,13 @@ if [ "$DO_NATIVE" = "true" ] ; then | |||
| fi | |||
|
|
|||
| if [ "$DO_CROSS" = "true" ] ; then | |||
| docker build -t alpine_node_artifact $base_dir/tools/docker/alpine_artifact | |||
There was a problem hiding this comment.
Why move this line up here?
There was a problem hiding this comment.
Thanks @murgatroid99 for the code review. Incorporated the review comments. Please check.
|
From the build failure log it looks like |
|
@murgatroid99 Updated the |
|
@shahidhs-ibm, does it get stuck even if you select a different company? |
|
@srini100 Yes, it gets stuck when I select different company. I tried clearing my browser cache and changing different browsers but the issue persists. |
|
@shahidhs-ibm Can you please try the EasyCLA authorization again? We think we have resolved the issue when selecting your company. Thanks. |
|
@WillsonHG Thank you. The issue in selecting company name is resolved and now my CLA check with EasyCLA is passing. However 'cla/linuxfoundation' check is still failing. I am checking with my company's CLA manager if he/she needs to correct/update something at their end. |
|
@shahidhs-ibm Glad that was resolved. I'm not sure why the older cla/linuxfoundation is still running on this repo. That is a question for the repo maintainer. But if you want to also pass that check, your CLA manager will need to add your email to the whitelist at identity.linuxfoundation.org The other thing that may be an issue is the user "root". Neither EasyCLA nor the cla/linuxfoundation is recognizing that user or its commit. Would you be able to author that commit instead? |
|
@WillsonHG Thank you for detailed response. Do you think that 'root' user commit is causing CLA issue? That commit was a mistake and I reverted it with new commit, however that entry remained and I can't author it. Shall I create a new PR? Any suggestion? |
|
We have a green check mark on the EasyCLA check. I think the CLA is fine. |
|
@murgatroid99 @WillsonHG Are we good on CLA front then? If yes then could you please review and merge? Please let me know if you have any comments / suggestions. |
|
I think this looks OK, but I want to make sure we're on the same page about maintenance. We, the gRPC team, cannot effectively maintain this build. As long as the build continues to work we will publish the resulting binaries, but if it breaks, you will need to fix that, and I do not want to block releases for long on those breakages. Will you be able to do that? |
|
@murgatroid99 We are OK to provide our commitment on the maintenance of s390x binaries. As per comment in issue, will it help if we provide s390x VMs? |
|
@murgatroid99 Thank you for merging the PR. Can we expect Pre-built binaries for s390x be available in next grpc release? Is there any way by which we can download s390x binaries for testing? |
|
We have recently been having some build problems that we are actively working on fixing. Once we get the build working, the next release will have whatever binaries come out of the build script, which should now include the s390x binaries. |
As per discussion in issue #296, creating this PR to add s390x cross compilation support. From this we also would like to provide tier3 support for the s390x architecture.