Limit ring hash max size to 4K #9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's quite a few parts from grpc/proposal#338 missing, as the xds resource processing also has to be adjusted to pass down 8 MB when unset. That's mostly internal, so I think the biggest thing that is needed before merging is some sort of option to change the limit. That was the biggest concern with this change. |
|
Sure we can add the option to this PR, but @ejona86 can you propose an API? |
ejona86
approved these changes
Nov 29, 2022
ejona86
added
the
TODO:backport
YifeiZhuang
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements grpc/proposal#338 for Java.
Note: a configuration option (preferable taking the form of a dial option, but possibly using a global) is left as a TODO.
cc @ejona86