xds: Fake control plane test setup code to Rules #9666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YifeiZhuang
reviewed
Nov 1, 2022
Comment on lines
+114
to
+116
| nameResolverProvider = XdsNameResolverProvider.createForTest(SCHEME, | ||
| defaultBootstrapOverride()); | ||
| NameResolverRegistry.getDefaultRegistry().register(nameResolverProvider); |
There was a problem hiding this comment.
Is it better to move to data plane?
There was a problem hiding this comment.
I included it here because my thinking was that this rule handles everything needed to make a control plane available to use, not just the server startup. And since registering this test nameserver is part of that, I'd keep it here.
There was a problem hiding this comment.
i see. My thinking was that this belongs to Data Plane while this file is called Control Plane. But thats monior.
YifeiZhuang
reviewed
Nov 1, 2022
xds/src/test/java/io/grpc/xds/FakeControlPlaneXdsIntegrationTest.java
Outdated
Show resolved
Hide resolved
This extracts the startup and shutdown code for the control and data plane server to reparate JUnit rules, which allows this logic to be resued in other tests in a simple manner. Also makes the test easier to read with the boiler plate init code removed.
temawi
force-pushed
the
xds-test
branch
2 times, most recently
from
82cb3d3
to
d6bbcad
Compare
YifeiZhuang
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the startup and shutdown code for the control and data plane server to separate JUnit rules, which allows this logic to be reused in other tests in a simple manner. Also makes the test easier to read with the boiler plate init code removed.