gcp-observability: add period to service filter regular expression in logging config #9631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcp-observability/src/main/java/io/grpc/gcp/observability/ObservabilityConfigImpl.java
Show resolved
Hide resolved
DNVindhya
added a commit
to DNVindhya/grpc-java
that referenced
this pull request
Oct 19, 2022
sanjaypujare
pushed a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
period(.)to the service name part of regular expression which is used to validate method or service filter provided in observability configuration.CC @sanjaypujare