gcp-observability: update observability logging proto #9608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcp-observability/src/main/proto/grpc/observabilitylog/v1/observabilitylog.proto
Show resolved
Hide resolved
|
CC @ejona86 since he might be interested in reviewing this as well |
gcp-observability/src/main/java/io/grpc/gcp/observability/logging/GcpLogSink.java
Outdated
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/logging/GcpLogSink.java
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/ObservabilityConfigImpl.java
Outdated
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/interceptors/LogHelper.java
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/interceptors/LogHelper.java
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/interceptors/LogHelper.java
Show resolved
Hide resolved
gcp-observability/src/main/proto/grpc/observabilitylog/v1/observabilitylog.proto
Show resolved
Hide resolved
gcp-observability/src/main/proto/grpc/observabilitylog/v1/observabilitylog.proto
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/logging/GcpLogSink.java
Show resolved
Hide resolved
| .setAuthority(authority) | ||
| .setType(eventType) | ||
| .setLogger(eventLogger) | ||
| .setPayload(pair.payloadBuilder) |
There was a problem hiding this comment.
pair can be null (line 243-245) in which case you will get NPE?
Before fixing the code, you should create a unit test that reproduces the NPE and then fix the code.
There was a problem hiding this comment.
Added a test to reproduce NPE. Added a null check before setting values of GrpcLogRecord using pair.
gcp-observability/src/main/java/io/grpc/gcp/observability/interceptors/LogHelper.java
Outdated
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/interceptors/LogHelper.java
Show resolved
Hide resolved
sanjaypujare
requested changes
Oct 12, 2022
gcp-observability/src/test/java/io/grpc/gcp/observability/interceptors/LogHelperTest.java
Outdated
Show resolved
Hide resolved
sanjaypujare
approved these changes
Oct 18, 2022
sergiitk
pushed a commit
to sergiitk/grpc-java
that referenced
this pull request
Oct 18, 2022
sergiitk
pushed a commit
to sergiitk/grpc-java
that referenced
this pull request
Oct 18, 2022
sergiitk
pushed a commit
that referenced
this pull request
Oct 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to observability logging data model / proto as per latest logging design review.
Explicit flush is removed to rely on default batching settings provided by Google Cloud Logging Client library.
Ref b/248096772