Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpclb: fix mismatched indices in addresses log #9602

Merged
merged 1 commit into from Oct 10, 2022
Merged

grpclb: fix mismatched indices in addresses log #9602

merged 1 commit into from Oct 10, 2022

Conversation

TrevorEdwards
Copy link
Contributor

I noticed these indices are mismatched, which led me to think some backends were resolved when they weren't.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 6, 2022
@ejona86 ejona86 requested a review from sergiitk October 6, 2022 21:00
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 6, 2022
@TrevorEdwards
Copy link
Contributor Author

@sergiitk @ejona86 Can one of you help merge this? I'm assuming GAE Interop was a flake.

@ejona86 ejona86 merged commit 73020a9 into grpc:master Oct 10, 2022
@TrevorEdwards TrevorEdwards deleted the patch-2 branch October 10, 2022 17:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TrevorEdwards @sergiitk @ejona86 @grpc-kokoro