okhttp: Add client transport proxy socket timeout #9586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having a timeout when reading the response from a proxy server can cause a hang if network connectivity is lost at the same time.
temawi
force-pushed
the
okhttp-proxy-timeout
branch
from
cea4755
to
11d48f1
Compare
ejona86
reviewed
Oct 4, 2022
okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java
Outdated
Show resolved
Hide resolved
okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java
Outdated
Show resolved
Hide resolved
okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Oct 4, 2022
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Oct 6, 2022
Not having a timeout when reading the response from a proxy server can cause a hang if network connectivity is lost at the same time.
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this pull request
Oct 10, 2022
Not having a timeout when reading the response from a proxy server can cause a hang if network connectivity is lost at the same time.
ejona86
pushed a commit
that referenced
this pull request
Oct 10, 2022
Not having a timeout when reading the response from a proxy server can cause a hang if network connectivity is lost at the same time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having a timeout when reading the response from a proxy server can cause a hang if network connectivity is lost at the same time.