Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: ringhash policy in TRANSIENT_FAILURE should not attempt connecti… #9535

Merged
merged 1 commit into from Sep 10, 2022

Conversation

YifeiZhuang
Copy link
Contributor

…ng when already in connecting

b/242583114

@YifeiZhuang YifeiZhuang merged commit 42e6814 into grpc:master Sep 10, 2022
@YifeiZhuang YifeiZhuang deleted the ring-hash branch September 10, 2022 00:27
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Sep 12, 2022
@ejona86
Copy link
Member

ejona86 commented Sep 12, 2022

@YifeiZhuang, we should probably backport this to 1.49, right? Does 1.48 need it as well (was it impacted; not whether we will release a patch release soon)?

@YifeiZhuang
Copy link
Contributor Author

YifeiZhuang commented Sep 12, 2022

@YifeiZhuang, we should probably backport this to 1.49, right? Does 1.48 need it as well (was it impacted; not whether we will release a patch release soon)?

the current behaviour dates back to 1.44 (#9085), before that there are more serious bugs.
So yes, both 1.48 and 1.49 are impacted. How far do we want to backport the change to?

YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Sep 12, 2022
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Sep 14, 2022
YifeiZhuang added a commit that referenced this pull request Sep 14, 2022
YifeiZhuang added a commit that referenced this pull request Sep 14, 2022
@YifeiZhuang YifeiZhuang removed the TODO:backport PR needs to be backported. Removed after backport complete label Sep 14, 2022
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants