[core,api,auth: Choose executor based on need for thread affinity #9504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing. Add an interface to differentiate whether the specific thread is needed. Fixes b/244209681
larry-safran
changed the title
ejona86
reviewed
Sep 2, 2022
auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java
Outdated
Show resolved
Hide resolved
auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java
Outdated
Show resolved
Hide resolved
auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java
Outdated
Show resolved
Hide resolved
auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
Did you forget to push the change? If you are still working on it that is fine; just want to make sure we aren't each waiting for the other. |
ejona86
approved these changes
Sep 3, 2022
auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java
Outdated
Show resolved
Hide resolved
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Sep 7, 2022
…pc#9504) * core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing. Add an interface to differentiate whether the specific thread is needed. Fixes b/244209681
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Sep 7, 2022
…pc#9504) * core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing. Add an interface to differentiate whether the specific thread is needed. Fixes b/244209681
This was referenced Sep 7, 2022
larry-safran
added a commit
that referenced
this pull request
Sep 12, 2022
) (#9525) * core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing. Add an interface to differentiate whether the specific thread is needed. Fixes b/244209681
larry-safran
added a commit
that referenced
this pull request
Sep 12, 2022
) (#9524) * core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing. Add an interface to differentiate whether the specific thread is needed. Fixes b/244209681
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Oct 6, 2022
…pc#9504) * core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing. Add an interface to differentiate whether the specific thread is needed. Fixes b/244209681
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing.
Add an interface to differentiate whether the specific thread is needed.
Fixes b/244209681