Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

okhttp: add max connection idle at OkHttpServerBuilder #9494

Merged
merged 4 commits into from Aug 29, 2022
Merged

okhttp: add max connection idle at OkHttpServerBuilder #9494

merged 4 commits into from Aug 29, 2022

Conversation

YifeiZhuang
Copy link
Contributor

No description provided.

ejona86
ejona86 reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

respondWithHttpError() also needs the active check.

@YifeiZhuang YifeiZhuang enabled auto-merge (squash) August 29, 2022 23:25
@YifeiZhuang YifeiZhuang merged commit 7291ad4 into grpc:master Aug 29, 2022
@YifeiZhuang YifeiZhuang deleted the okhttp-idle-manager branch August 29, 2022 23:29
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Sep 7, 2022
@YifeiZhuang
Revert "okhttp: add max connection idle at OkHttpServer (grpc#9494)"
9b4bf49 
This reverts commit 7291ad4.
YifeiZhuang added a commit that referenced this pull request Sep 8, 2022
@YifeiZhuang
Revert "okhttp: add max connection idle at OkHttpServer (#9494)" (#9528)
95b9d6d 
This reverts commit 7291ad4.
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Sep 9, 2022
@YifeiZhuang
Revert "Revert "okhttp: add max connection idle at OkHttpServer (grpc…
9571eb8 
…#9494)" (grpc#9528)"

This reverts commit 95b9d6d.
@YifeiZhuang YifeiZhuang mentioned this pull request Sep 9, 2022
Merged
YifeiZhuang added a commit that referenced this pull request Sep 9, 2022
@YifeiZhuang
okhttp: add max connection idle at OkHttpServer and fix test (#9533)
eac4178 
* Revert "Revert "okhttp: add max connection idle at OkHttpServer (#9494)" (#9528)"

This reverts commit 95b9d6d and fixed flaky test.
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
@YifeiZhuang @larry-safran
okhttp: add max connection idle at OkHttpServer (grpc#9494)
1113446
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
@YifeiZhuang @larry-safran
Revert "okhttp: add max connection idle at OkHttpServer (grpc#9494)" (g…
97e400a 
…rpc#9528)

This reverts commit 7291ad4.
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
@YifeiZhuang @larry-safran
okhttp: add max connection idle at OkHttpServer and fix test (grpc#9533)
62bcd32 
* Revert "Revert "okhttp: add max connection idle at OkHttpServer (grpc#9494)" (grpc#9528)"

This reverts commit 95b9d6d and fixed flaky test.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YifeiZhuang @ejona86