core: Update outlier detection max ejection logic. #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of strictly enforcing the max ejection percentage setting, allow one additional ejection past the maximum. This quarantees at least one ejection and matches Envoy proxy behavior.
temawi
requested review from
murgatroid99,
ejona86 and
larry-safran
and removed request for
ejona86
larry-safran
approved these changes
Aug 24, 2022
murgatroid99
approved these changes
Aug 24, 2022
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Sep 15, 2022
Instead of strictly enforcing the max ejection percentage setting, allow one additional ejection past the maximum. This quarantees at least one ejection and matches Envoy proxy behavior.
temawi
added a commit
that referenced
this pull request
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of strictly enforcing the max ejection percentage setting,
allow one additional ejection past the maximum. This quarantees at least
one ejection and matches Envoy proxy behavior.