xds: Fix outlier detection env flag name. #9462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,8 +169,8 @@ final class ClientXdsClient extends XdsClient implements XdsResponseHandler, Res | |||
| || Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_XDS_CUSTOM_LB_CONFIG")); | |||
| @VisibleForTesting | |||
| static boolean enableOutlierDetection = | |||
| !Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_XDS_OUTLIER_DETECTION")) | |||
| || Boolean.parseBoolean(System.getenv("GRPC_EXPERIMENTAL_XDS_OUTLIER_DETECTION")); | |||
| !Strings.isNullOrEmpty(System.getenv("GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION")) | |||
There was a problem hiding this comment.
Looking at the other env var names used we are not consistent in using "ENABLE" in the name. Is ENABLE the new thing or not having ENABLE is the new thing?
There was a problem hiding this comment.
Yeah, we are not consistent with all of these, but this is what the outlier detection gRFC specifies, so that's what I'm going with here.
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Aug 22, 2022
temawi
added a commit
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.