xds: Configure outlier detection. #9456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temawi
force-pushed
the
outlier-detection-xds
branch
from
b0f4107
to
7583f30
Compare
ejona86
reviewed
Aug 18, 2022
temawi
force-pushed
the
outlier-detection-xds
branch
from
7583f30
to
b876bea
Compare
larry-safran
approved these changes
Aug 18, 2022
| // load balancer. | ||
| if (outlierDetection != null) { | ||
| LoadBalancerProvider outlierDetectionProvider = lbRegistry.getProvider( | ||
| "outlier_detection_experimental"); |
There was a problem hiding this comment.
This should be a constant like the rest of the policy names.
There was a problem hiding this comment.
There wasn't really a nice place to put it, since the constant file in the xds project is for xds load balancers - which this is not as it lives in core. There is a plan to move the load balancer over to this project though so we can introduce a constant at that point.
There was a problem hiding this comment.
Okay. I would have put it in the OutlierDectionLoadBalanceProvider class itself, but waiting until later is fine.
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Aug 22, 2022
Enables the new OutlierDetectionLoadBalancer when outlier detection is enabled in the xDS cluster configuration.
temawi
added a commit
that referenced
this pull request
Aug 22, 2022
Enables the new OutlierDetectionLoadBalancer when outlier detection is enabled in the xDS cluster configuration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the new
OutlierDetectionLoadBalancerwhen outlier detection is enabledin the xDS cluster configuration.