Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlier detection load balancer #9447

Merged
merged 18 commits into from Aug 18, 2022
Merged

Outlier detection load balancer #9447

merged 18 commits into from Aug 18, 2022

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Aug 14, 2022

Implements a new load balancer that tracks all RPC results to the addresses it is configured with and periodically attempts to detect outlier. It wraps a child load balancer that it hides any addresses that are deemed outliers.

Implementation follows the specification in gRFC A50: gRPC xDS Outlier Detection Support

@temawi temawi force-pushed the outlier-detection branch 5 times, most recently from 18bb3f4 to d275d72 Compare August 15, 2022 03:32
@temawi temawi marked this pull request as ready for review August 15, 2022 05:05
@temawi
Copy link
Contributor Author

temawi commented Aug 15, 2022

cc:
@ejona86
@murgatroid99

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ejection algorithms mostly look good, but I found a few issues.

@temawi temawi merged commit 128688a into grpc:master Aug 18, 2022
@temawi temawi deleted the outlier-detection branch August 18, 2022 15:46
temawi added a commit to temawi/grpc-java that referenced this pull request Aug 22, 2022
New outlier detection load balancer.

Tracks all RPC results to the addresses it is configured with and periodically attempts
to detect outlier. It wraps a child load balancer from which it hides any addresses that
are deemed outliers.

As specified in gRFC A50: gRPC xDS Outlier Detection Support:
https://github.com/grpc/proposal/blob/master/A50-xds-outlier-detection.md
temawi added a commit that referenced this pull request Aug 22, 2022
New outlier detection load balancer.

Tracks all RPC results to the addresses it is configured with and periodically attempts
to detect outlier. It wraps a child load balancer from which it hides any addresses that
are deemed outliers.

As specified in gRFC A50: gRPC xDS Outlier Detection Support:
https://github.com/grpc/proposal/blob/master/A50-xds-outlier-detection.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants