Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repositories.bzl: Use valid target name for grpc-services #9422

Merged
merged 2 commits into from Aug 2, 2022

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Aug 2, 2022

This fixes builds including dependencies from Maven that use
io.grpc:grpc-services. It resolves this error:

no such target '@io_grpc_grpc_java//services:services': target 'services' not declared in package 'services' defined by services/BUILD.bazel and referenced by '@maven//:io_grpc_grpc_services'

Fixes #9419

CC @xushaoxiao

This fixes builds including dependencies from Maven that use
io.grpc:grpc-services. It resolves this error:
```
no such target '@io_grpc_grpc_java//services:services': target 'services' not declared in package 'services' defined by services/BUILD.bazel and referenced by '@maven//:io_grpc_grpc_services'
```

Fixes grpc#9419
repositories.bzl Outdated Show resolved Hide resolved
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Added a comment about xds also needing a similar change

Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit db320ce into grpc:master Aug 2, 2022
@ejona86 ejona86 deleted the bazel-services_maven branch August 2, 2022 17:28
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Aug 2, 2022
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Aug 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc-services module need a bazel target "services"
3 participants