gcp-observability: add custom tags to metrics and traces using Stackdriver config-builders #9407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…river config-builders
temawi
reviewed
Jul 25, 2022
Comment on lines
158
to
162
| Map<LabelKey, LabelValue> constantLabels = new HashMap<>(); | ||
| for (Map.Entry<String, String> mapEntry : customTags.entrySet()) { | ||
| constantLabels.put(LabelKey.create(mapEntry.getKey(), mapEntry.getKey()), | ||
| LabelValue.create(mapEntry.getValue())); | ||
| } |
There was a problem hiding this comment.
Just a nit, but for a mundane map translation, something like this might be more succinct:
Map<LabelKey, LabelValue> constantLabels = customTags.entrySet().stream()
.collect(Collectors.toMap(k -> LabelKey.create(k, k), v -> LabelValue.create(v)));
Same for your other map translation.
There was a problem hiding this comment.
It needs to be this: do you agree?
Map<LabelKey, LabelValue> constantLabels = customTags.entrySet().stream()
.collect(Collectors.toMap(k -> LabelKey.create(k.getKey(), k.getKey()),
v -> LabelValue.create(v.getValue())));
because k and v are Map.Entry (and not Map.Key and Map.Value)
There was a problem hiding this comment.
Ah yes - I did say "something like this" ;-)
temawi
approved these changes
Jul 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @DNVindhya to provide context/background of this task to the reviewer(s)