xds: implement ignore_resource_deletion server feature #9339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
added
TODO:backport
sergiitk
changed the title
sergiitk
force-pushed
the
xds-ignore_resource_deletion
branch
5 times, most recently
from
6866bf3
to
1b81cfd
Compare
sergiitk
force-pushed
the
xds-ignore_resource_deletion
branch
from
1b81cfd
to
48f331c
Compare
sergiitk
force-pushed
the
xds-ignore_resource_deletion
branch
from
48f331c
to
0f9fdd9
Compare
ejona86
reviewed
Jul 8, 2022
There was a problem hiding this comment.
The parameterization of the test is fine, but I do think we should strive to be able to remove it in the future. Just a few test cases should care about the bootstrap value, so we could just run some tests with a different bootstrap. (For the few tests impacted, we can parameterize manually by passing in a boolean argument.) We're going to have more of these sorts of bootstrap options over time and adding another test dimension each time will lead to pain. But this is fine now for expediency.
ejona86
approved these changes
Jul 8, 2022
|
FYI @erikjoh |
sergiitk
added a commit
to sergiitk/grpc-java
that referenced
this pull request
Jul 8, 2022
As defined in the gRFC [A53: Option for Ignoring xDS Resource Deletion](https://github.com/grpc/proposal/blob/master/A53-xds-ignore-resource-deletion.md). This includes semi-related changes: * Refactor ClientXdsClientTestBase: extract verify methods for golden resources * Parameterize ClientXdsClientV2Test and ClientXdsClientV3Test with ignoreResourceDeletion enabled and disabled * Add FORCE_INFO and FORCE_WARNING levels to XdsLogLevel
sergiitk
added a commit
that referenced
this pull request
Jul 8, 2022
As defined in the gRFC [A53: Option for Ignoring xDS Resource Deletion](https://github.com/grpc/proposal/blob/master/A53-xds-ignore-resource-deletion.md). This includes semi-related changes: * Refactor ClientXdsClientTestBase: extract verify methods for golden resources * Parameterize ClientXdsClientV2Test and ClientXdsClientV3Test with ignoreResourceDeletion enabled and disabled * Add FORCE_INFO and FORCE_WARNING levels to XdsLogLevel
|
Backported to |
sergiitk
removed
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in the gRFC A53: Option for Ignoring xDS Resource Deletion.
Note for the reviewer: it'll probably be more convenient to review commit-by-commit. The test refactoring commit can be skipped: it's not required, but was very handy for implementing new tests, and modifying the old ones.