api: Explain security constraints of ATTR_AUTHORITY_OVERRIDE #9281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half of the text was copied from NameResolver.getServiceAuthority(). However, that method can't perform I/O (which would block) so more text was appropriate here to mention the implications of having a remote service provide the authority. I noticed the text was lacking while discussing grpc#9266.
temawi
reviewed
Jun 15, 2022
| @@ -40,6 +40,11 @@ public final class EquivalentAddressGroup { | |||
| * However, if the channel has overridden authority via | |||
| * {@link ManagedChannelBuilder#overrideAuthority(String)}, the transport will use the channel's | |||
| * authority override. | |||
| * | |||
| * <p>The authority <strong>must</strong> be from a trusted source, because if the authority is | |||
| * tampered with RPCs may be sent to attackers which may leak sensitive user data. If the | |||
There was a problem hiding this comment.
"tampered with, RPCs may be..."
temawi
approved these changes
Jun 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half of the text was copied from NameResolver.getServiceAuthority().
However, that method can't perform I/O (which would block) so more text
was appropriate here to mention the implications of having a remote
service provide the authority.
I noticed the text was lacking while discussing #9266.