Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Custom LB configs to support UDPA TypeStruct #9198

Merged
merged 3 commits into from May 24, 2022

Conversation

temawi
Copy link
Contributor

@temawi temawi commented May 24, 2022

The legacy com.github.udpa.udpa.type.v1.TypedStruct proto should be supported in addition to the current com.github.udpa.udpa.type.v1.TypedStruct one.

The legacy com.github.udpa.udpa.type.v1.TypedStruct proto should be supported in addition to the current com.github.udpa.udpa.type.v1.TypedStruct one.
@temawi temawi requested a review from sergiitk May 24, 2022 18:20
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestion.

temawi and others added 2 commits May 24, 2022 11:33
Co-authored-by: Sergii Tkachenko <hi@sergii.org>
Co-authored-by: Sergii Tkachenko <hi@sergii.org>
@temawi temawi merged commit de3388b into grpc:master May 24, 2022
@temawi temawi deleted the use_udpa_typestruct branch May 24, 2022 20:55
@temawi temawi added the TODO:backport PR needs to be backported. Removed after backport complete label May 26, 2022
temawi added a commit to temawi/grpc-java that referenced this pull request May 27, 2022
* xds: Custom LB configs to support UDPA TypeStruct

The legacy com.github.udpa.udpa.type.v1.TypedStruct proto should be supported in addition to the current com.github.udpa.udpa.type.v1.TypedStruct one.

Co-authored-by: Sergii Tkachenko <hi@sergii.org>
temawi added a commit that referenced this pull request May 27, 2022
* xds: Custom LB configs to support UDPA TypeStruct

The legacy com.github.udpa.udpa.type.v1.TypedStruct proto should be supported in addition to the current com.github.udpa.udpa.type.v1.TypedStruct one.

Co-authored-by: Sergii Tkachenko <hi@sergii.org>
@temawi temawi removed the TODO:backport PR needs to be backported. Removed after backport complete label May 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants