Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Don't end status with '.' in XdsNameResolver (1.45.x backport) #8965

Merged
merged 1 commit into from Mar 8, 2022
Merged

xds: Don't end status with '.' in XdsNameResolver (1.45.x backport) #8965

merged 1 commit into from Mar 8, 2022

Conversation

YifeiZhuang
Copy link
Contributor

backport of #8958

@ejona86 @YifeiZhuang
xds: Don't end status with '.' in XdsNameResolver (grpc#8958)
ef7bfcf 
2a45524 introduced '.' to the end of some status descriptions. We
typically don't end status descriptiosn in periods, but that's minor. In
this case though if the causal status ends in period then the new status
will end in two periods, which could easily be confusing to users.
@YifeiZhuang YifeiZhuang requested a review from ejona86 March 4, 2022 00:55
ejona86
ejona86 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't that big of a deal. It would have been fine not to backport, but it is good to do so.

@YifeiZhuang YifeiZhuang merged commit 6844f06 into grpc:v1.45.x Mar 8, 2022
@YifeiZhuang YifeiZhuang deleted the xds-err-msg branch March 8, 2022 23:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YifeiZhuang @ejona86