Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Squelch ADS reconnection error logs (1.45.x backport) #8942

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Feb 23, 2022

Workaround for #8886, as we wait on a real fix. The regular load
balancing disconnections are confusing users and will train users to
start ignoring gRPC warnings. At present, it is better to have no log
than excessively log.

CC @YifeiZhuang, @erikjoh


Backport of #8941

Workaround for grpc#8886, as we wait on a real fix. The regular load
balancing disconnections are confusing users and will train users to
start ignoring gRPC warnings. At present, it is better to have no log
than excessively log.
Copy link
Contributor

@erikjoh erikjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also confirm that the warnings disappear after this change.

@ejona86 ejona86 merged commit 1b1b284 into grpc:v1.45.x Feb 24, 2022
@ejona86 ejona86 deleted the backport-8886-workaround-1.45 branch March 2, 2022 15:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants