Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls: fix RLS lb name #8867

Merged
merged 1 commit into from
Jan 25, 2022
Merged

rls: fix RLS lb name #8867

merged 1 commit into from
Jan 25, 2022

Conversation

dapengzhang0
Copy link
Member

@dapengzhang0 dapengzhang0 commented Jan 25, 2022 •
edited

As pointed out by @easwars , the lb name of RLS lb should be "rls_experimental" instead of "rls-experimental", using underscore like "round_robin".

sergiitk
sergiitk approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this makes sense. Recently I renamed ring_hash to ring_hash_experimental (#8867), so it's definitely a pattern.

@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 25, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 25, 2022
@dapengzhang0 dapengzhang0 merged commit 7c49e56 into grpc:master Jan 25, 2022
@dapengzhang0 dapengzhang0 deleted the fix-rls-lb-name branch January 25, 2022 20:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dapengzhang0 @sergiitk @grpc-kokoro