Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.44.0 release, version bump #8862

Merged
merged 3 commits into from Jan 25, 2022
Merged

1.44.0 release, version bump #8862

merged 3 commits into from Jan 25, 2022

Conversation

YifeiZhuang
Copy link
Contributor

No description provided.

@dapengzhang0
Copy link
Member

dapengzhang0 commented Jan 24, 2022

In the 1st commit, we should make the following change:

  • README.md: gRPC-Java works with JDK 7 -> gRPC-Java works with JDK 8
  • build.gradle: protobufVersion = '3.19.1' -> protobufVersion = '3.19.2'
  • protoc version 3.19.1 to 3.19.2
    L115 <protocArtifact>com.google.protobuf:protoc:3.19.1:exe:${os.detected.classifier}</protocArtifact>
    L143 artifact = "com.google.protobuf:protoc:3.19.1"

@dapengzhang0
Copy link
Member

dapengzhang0 commented Jan 25, 2022

@YifeiZhuang Can you rebase, by moving and squashing the last commit with the first commit?

git rebase -i HEAD~4

pick 1st commit
s 4th commit
pick 2nd commit
pick 3rd commit

And then force push to the PR?

@YifeiZhuang YifeiZhuang merged commit 301d82c into grpc:v1.44.x Jan 25, 2022
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Jan 25, 2022
YifeiZhuang added a commit that referenced this pull request Jan 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
@YifeiZhuang YifeiZhuang deleted the release branch July 19, 2022 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants