Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: update netty to 4.1.72.Final and tcnative to 2.0.46.Final #8780

Merged
merged 4 commits into from Jan 7, 2022
Merged

all: update netty to 4.1.72.Final and tcnative to 2.0.46.Final #8780

merged 4 commits into from Jan 7, 2022

Conversation

sanjaypujare
Copy link
Contributor

fixes #8617

@sanjaypujare
Copy link
Contributor Author

Closing as there are test failures...

@sanjaypujare sanjaypujare reopened this Dec 22, 2021
@sergiitk
Copy link
Member

Also fixes #8781.

@sergiitk sergiitk mentioned this pull request Dec 22, 2021
Closed
@dapengzhang0
Copy link
Member

Normally there are also bazel and markdown files that need to be changed accordingly. Seem #8167 for example.

@sanjaypujare
xds: fix Executor.execute to actually run the Runnable passed. Becaus…
2613ed1 
…e of the netty fix to actually use

the executor passed to the SslHandler we now need the Executor to execute.
@sanjaypujare
Copy link
Contributor Author

Normally there are also bazel and markdown files that need to be changed accordingly. Seem #8167 for example.

Done. PTAL

@sanjaypujare sanjaypujare added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Dec 23, 2021
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Dec 23, 2021
@dapengzhang0 dapengzhang0 changed the title xds: update netty to 4.1.72.Final and tcnative to 2.0.46.Final all: update netty to 4.1.72.Final and tcnative to 2.0.46.Final Dec 23, 2021
@sanjaypujare
Copy link
Contributor Author

@sergiitk as discussed offline. Tests now should be passing.

@sanjaypujare
Copy link
Contributor Author

@dapengzhang0 just a reminder for the review. Also CC @ejona86

@dapengzhang0
Copy link
Member

FYI @sanjaypujare ,

I merged #8801 , so now you can download the failed test report as shown in the picture to see the full Standard error by opening the index.html file in the browser.

@sanjaypujare
Copy link
Contributor Author

FYI @sanjaypujare ,

I merged #8801 , so now you can download the failed test report as shown in the picture to see the full Standard error by opening the index.html file in the browser.

Thanks @dapengzhang0 ! Will do

This was referenced Jan 6, 2022
Closed
Closed
sergiitk
sergiitk approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

buildscripts/kokoro/macos.cfg Show resolved Hide resolved
@sanjaypujare sanjaypujare merged commit d7f951a into grpc:master Jan 7, 2022
@sanjaypujare sanjaypujare deleted the netty-upgrade-4.1.72.final branch January 7, 2022 23:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dapengzhang0 dapengzhang0 dapengzhang0 left review comments

@sergiitk sergiitk sergiitk approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need compatible versions for Netty 4.1.68+ , GRPC server and netty-tcnative-boringssl-static
5 participants
@sanjaypujare @sergiitk @dapengzhang0 @ejona86 @grpc-kokoro