Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildscripts: add config for building grpc-binder artifact #8722

Merged
merged 1 commit into from Nov 23, 2021

Conversation

markb74
Copy link
Contributor

@markb74 markb74 commented Nov 22, 2021

Without this, grpc-binder isn't published to maven.

@markb74
Copy link
Contributor Author

markb74 commented Nov 23, 2021

Not sure if this is the right choice, and I'd love advice on how to test this.

@markb74 markb74 requested a review from ejona86 November 23, 2021 12:24
@markb74 markb74 changed the title Special case grpc-binder for android releases. buildscripts: add config for building grpc-binder artifact Nov 23, 2021
@ejona86
Copy link
Member

ejona86 commented Nov 23, 2021

You can dig through the output results of linux artifacts, and see that grpc-binder is now appropriately there:
https://console.cloud.google.com/storage/browser/grpc-testing-kokoro-prod/test_result_public/prod/grpc/java/master/presubmit/linux_artifacts/5753/20211123-042837/github/grpc-java/mvn-artifacts/io/grpc/grpc-binder/1.43.0-SNAPSHOT

upload_artifacts.sh is more annoying to test, but the change looks right.

@markb74 markb74 merged commit ee581bf into grpc:master Nov 23, 2021
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Nov 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants